Code review comment for lp://qastaging/~elementary-pantheon/scratch/confirm-heavy-files

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

I needed to merge the trunk before it would build (although there were no conflicts).

Since AlertView is presumably intended for some kind of warning, it is strange that the option for a cancel button is missing but that should be fixed in Granite if required. It would also make sense for the font sizes to match those in the Welcome widget.

It would be good to combine the check with one for content-type but that could be left to another branch.

The branch works as described but in my opinion the phrase "very heavy files" may be mistranslated and should be something more specific such as "files exceeding 1Mb in size" so the user knows which files they *can* open.

review: Needs Fixing (ux)

« Back to merge proposal