Code review comment for lp://qastaging/~ev/ubuntu-ci-services-itself/better-structure-and-logging

Revision history for this message
Andy Doan (doanac) wrote :

Just nits - nothing worth not merging over:

django hook.py
1131 - p = 'PYTHONPATH=%s' % config_data.get('python_path', install_root)
1132 + def_path = '%s:%s' % (config_dir, code_dir)
1133 + p = 'PYTHONPATH=%s' % config_data.get('python_path', def_path)

1269 - relation_set({'python_path': install_root})
1270 + relation_set({'python_path': '%s:%s' % (config_dir, code_dir)})

I think the relation_set should use the same logic as line 1133 uses?

ppa-assigner.yaml:
1468 + python_path: /srv/ppa_django/conf:/srv/ppa_django/code/ci-utils:/srv/ppa_django/code/ppa-assigner

Is this needed now, or should the relation_set (now that its been updated) handle this setting properly.

Untested by me.

review: Approve

« Back to merge proposal