Code review comment for lp://qastaging/~evfool/scratch/lp1309291

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

There are some problems with the search function, which can be demonstrated as follows (All extensions turned off):

1) Create a new document consisting of a blank line followed by a line with one word on it followed by another blank line.
2) Type the word into the search box - it is found and selected, the arrows next to the search box are inactive (correct)
3) Place the cursor on the last blank line - the word is not highlighted (incorrect) but the up arrow is active (correct).
4) Press the up arrow - the word is not found and both arrows become inactive (incorrect)
5) Click in the search box - the word appears red indicating it does not occur in the document (incorrect).
6) Retype the word in the box - it is found and selected again (correct)
7) Place the cursor on the first blank line - the up arrow becomes active instead of the down arrow (incorrect)
8) CLick in the search field - the text does not become red (compare point 5).
9) Type something in the replace field - the buttons are active (correct)
10) Press "Replace" - nothing is replaced and the buttons stay active (incorrect)
11) Press "Replace all" - nothing is replaced and the bottoms become inactive (incorrect)

I would prefer the search to be always case sensitive by default. At the moment it is only case-sensitive if the search term is mixed case and I do not see the utility of this. Perhaps there could be a setting or tick-box to control case sensitivity.

There are some one line if statements - do these comply with the code style guidelines?

The program freezes when searching in certain machine generated text files (e.g. web pages, rtf files) but gdb indicated this to be a bug in Gtk (gedit had the same problem).

review: Needs Fixing

« Back to merge proposal