Code review comment for lp://qastaging/~evfool/scratch/lp1309291

I agree Daniel needs to decide the desired behaviour regarding case
sensitivity. There may have been a good design or technical reason why it
is like this. I now see that gedit behaves the same way. Its not an issue
that would prevent approval of this branch anyway as it was pre-existing.

On 26 May 2014 09:11, Robert Roth <email address hidden> wrote:

> Thanks Jeremy for the detailed testing, I will look into the issues you
> have reported later in the afternoon.
>
> Regarding the case sensitivity: the behaviour is the same as it was before
> (case sensitive only if the search text is mixed-case), we should ask
> Daniel Fore whether we want a checkbox for case sensitivity or not?
>
> As for the incorrect behaviour: my hunch is that it has something to do
> with the wrap-around setting used as false by default (even before this
> merge [1]), and not changed anywhere.
>
> [1]
> http://bazaar.launchpad.net/~elementary-apps/scratch/scratch/view/head:/src/Widgets/SearchManager.vala#L58
> --
> https://code.launchpad.net/~evfool/scratch/lp1309291/+merge/219621
> You are reviewing the proposed merge of lp:~evfool/scratch/lp1309291 into
> lp:scratch.
>