Code review comment for lp://qastaging/~faenil/ubuntu-ui-toolkit/moreScrollbarOptimizations

Revision history for this message
Cris Dywan (kalikiana) wrote :

There seems to be no test verifying that __initializedFlickable is null before it's completed. By extension calling scrollToBeginning, scrollToEnd and sliderPos in that case to see that they don't throw errors.

The new files src/Ubuntu/UbuntuToolkit/privates/ucscrollbarutils.{cpp,h} have no license headers.

Could you add a comment to the places where you dropped Qt.resolvedUrl? It's not obvious why you wouldn't use it - and without a comment it might get added again and we'd be losing the optimization.

review: Needs Fixing

« Back to merge proposal