camera-app

Merge lp://qastaging/~fboucault/camera-app/orientation_lock_fix into lp://qastaging/camera-app

orientation_lock_fix
Merge into trunk

Proposed by Florian Boucault on 2015-03-10

Status:

Merged

Approved by:

Bill Filler on 2015-03-17

Approved revision:

534

Merged at revision:

536

Proposed branch:

lp://qastaging/~fboucault/camera-app/orientation_lock_fix

Merge into:

lp://qastaging/camera-app

Diff against target:

58 lines (+33/-1)

1 file modified

ViewFinderOverlay.qml (+33/-1)

To merge this branch:

bzr merge lp://qastaging/~fboucault/camera-app/orientation_lock_fix

Related bugs:

Bug #1422762: Camera should not change behavior when rotation lock is on	High	Fix Released
Bug #1428272: Recording video with rotation lock on results in aspect ratio error in resultant video file	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-03-10
Ubuntu Phablet Team		2015-03-10	Pending
Review via email: mp+252428@code.qastaging.launchpad.net

Commit message

Fix photos/videos when shooting/recording with orientation lock on by not relying on the app orientation returned by unity8 but instead the device orientation itself.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-10:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/409/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2015-03-11:

will need some sort of test for this to land

Revision history for this message

Florian Boucault (fboucault) wrote on 2015-03-11:

Will write a manual test because automated testing is not really possible
as of yet for lack of ability to set the device's orientation
programatically. Work is in progress to fill that gap:
https://code.launchpad.net/~canonical/unity8/fake_platform_sensors_module/+merge/247334

On Wed, Mar 11, 2015 at 3:29 PM, Bill Filler <email address hidden>
wrote:

> will need some sort of test for this to land
> --
>
> https://code.launchpad.net/~fboucault/camera-app/orientation_lock_fix/+merge/252428
> You are the owner of lp:~fboucault/camera-app/orientation_lock_fix.
>

Revision history for this message

Florian Boucault (fboucault) wrote on 2015-03-11:

Manual test now added to test plan.

> Will write a manual test because automated testing is not really possible
> as of yet for lack of ability to set the device's orientation
> programatically. Work is in progress to fill that gap:
> https://code.launchpad.net/~canonical/unity8/fake_platform_sensors_module/+mer
> ge/247334
>
> On Wed, Mar 11, 2015 at 3:29 PM, Bill Filler <email address hidden>
> wrote:
>
> > will need some sort of test for this to land
> > --
> >
> > https://code.launchpad.net/~fboucault/camera-
> app/orientation_lock_fix/+merge/252428
> > You are the owner of lp:~fboucault/camera-app/orientation_lock_fix.
> >