Code review comment for lp://qastaging/~fboucault/unity-2d/dash_preferred_apps_gio

Revision history for this message
Florian Boucault (fboucault) wrote :

> The code looks good and functional tests are good (I tested switching my
> e-mail client from Evolution to Thunderbird, and my web browser between
> Chromium, Firefox and Opera).

Fantastic, thanks.

>
> Once the two previous remarks are addressed, this can be merged.
>
> Question: what is missing to also migrate the other default applications
> (picture viewer and media player) to this new technique?

It actually only works on Oneiric so I left it out of the MR; that is the GNOME settings UI only uses those for picture viewer and media player in Oneiric.

« Back to merge proposal