Code review comment for lp://qastaging/~fboucault/unity-2d/fix_nested_grid_view_positioning

Revision history for this message
Florian Boucault (fboucault) wrote :

Hmm, I cannot remember why that condition was introduced (it's not coming from this patch really but from an earlier revision in that code (see flickable.height > 0):

25 - onCompensateYChanged: {
26 - if (flickable.height > 0 && totalHeight >= flickable.height) {
27 - y = compensateY
28 - contentY = compensateY
29 - }
30 - }

I suppose that in some cases the flickable.height were negative but I would need to investigate to figure out if it's ever the case.

« Back to merge proposal