Code review comment for lp://qastaging/~fboucault/unity-2d/fix_nested_grid_view_positioning

Revision history for this message
Olivier Tilloy (osomon) wrote :

Agreed.
Could you please add a tiny comment before the declaration of compensateY to explain that the test (flickable.height < 0) is probably useless, but that removing it would require thorough testing.
This is just in case someone else than you has to read through this code before it’s replaced. As you commented, this piece of code is tricky, so explanatory comments are welcome.

Then let’s have this merged!

review: Approve (code)

« Back to merge proposal