Code review comment for lp://qastaging/~fhd/unity-2d/fix-for-bug-6600100
Revision history for this message
| Felix H. Dahlke (fhd) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> > > One UX issue: the option should be present in the menu only if it can
> > succeed,
> > > that is concretely if g_drive_can_stop returns true.
> >
> > How about the eject operation? It is always visible, not only when
> > g_volume_can_eject returns true.
>
> I suppose the user wants to have a fallback in case neither g_volume_can_eject
> nor g_volume_can_stop return true that will call unmount.
Okay, I'll just add the check for safely remove then.