Code review comment for lp://qastaging/~fhd/unity-2d/fix-for-bug-6600100

Revision history for this message
Marco Biscaro (marcobiscaro2112) wrote :

The code looks good. +1 for me.

> But isn't it possible that the drive becomes stoppable/unstoppable between the creation of the launcher icon and the user triggering "safely remove"?

I think this doesn't happens (afaik, the method g_drive_can_stop returns the correct information as soon as the drive is mounted and this info doesn't change after that).

review: Approve

« Back to merge proposal