Merge lp://qastaging/~frankban/juju-quickstart/version-handling into lp://qastaging/juju-quickstart
Status: | Merged |
---|---|
Merged at revision: | 56 |
Proposed branch: | lp://qastaging/~frankban/juju-quickstart/version-handling |
Merge into: | lp://qastaging/juju-quickstart |
Diff against target: |
669 lines (+159/-159) 8 files modified
quickstart/__init__.py (+1/-1) quickstart/app.py (+35/-39) quickstart/manage.py (+12/-3) quickstart/settings.py (+3/-0) quickstart/tests/test_app.py (+67/-89) quickstart/tests/test_manage.py (+31/-14) quickstart/tests/test_utils.py (+6/-9) quickstart/utils.py (+4/-4) |
To merge this branch: | bzr merge lp://qastaging/~frankban/juju-quickstart/version-handling |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+210395@code.qastaging.launchpad.net |
Description of the change
Improve version handling.
Modify the app.ensure_
so that it returns the Juju version tuple.
This way we allow for reusing the version
through the app and we can avoid calling
"juju version" multiple times.
Support local environments by installing
the juju-local meta-package in place of
specific packages (e.g. lxc, mongo).
This way we don't have to update quickstart
if core devs introduce new local env
dependencies.
Fix the destroy-environment message displayed
at the end of the process. The -e flag is
included when an old Juju is used.
Tests: `make check`.
QA: no strictly required.
Use .venv/bin/python juju-quickstart, check everything
works well, check the destroy-environment message
at the end of the process.
Reviewers: mp+210395_ code.launchpad. net,
Message:
Please take a look.
Description:
Improve version handling.
Modify the app.ensure_ dependencies function
so that it returns the Juju version tuple.
This way we allow for reusing the version
through the app and we can avoid calling
"juju version" multiple times.
Support local environments by installing
the juju-local meta-package in place of
specific packages (e.g. lxc, mongo).
This way we don't have to update quickstart
if core devs introduce new local env
dependencies.
Fix the destroy-environment message displayed
at the end of the process. The -e flag is
included when an old Juju is used.
Tests: `make check`.
QA: no strictly required.
Use .venv/bin/python juju-quickstart, check everything
works well, check the destroy-environment message
at the end of the process.
https:/ /code.launchpad .net/~frankban/ juju-quickstart /version- handling/ +merge/ 210395
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/74010044/
Affected files (+161, -159 lines): __init_ _.py manage. py settings. py tests/test_ app.py tests/test_ manage. py tests/test_ utils.py
A [revision details]
M quickstart/
M quickstart/app.py
M quickstart/
M quickstart/
M quickstart/
M quickstart/
M quickstart/
M quickstart/utils.py