Code review comment for lp://qastaging/~frankban/juju-quickstart/version-handling

Revision history for this message
Francesco Banconi (frankban) wrote :

Thank you for the review!

https://codereview.appspot.com/74010044/diff/1/quickstart/settings.py
File quickstart/settings.py (right):

https://codereview.appspot.com/74010044/diff/1/quickstart/settings.py#newcode34
quickstart/settings.py:34: # The path to the Juju command.
On 2014/03/11 13:24:24, rharding wrote:
> can/should we get this via `which juju`? I guess it shouldn't change.

We can but I am not sure we should. We call juju with sudo, and we use
the complete path for that security reason. AFAICT using `which` would
reintroduce the problem ,and at that point it would be easier to just
call `juju`.

https://codereview.appspot.com/74010044/

« Back to merge proposal