OpenStack Compute (nova)

Merge lp://qastaging/~fred-yang/nova/TrustedComputingPools into lp://qastaging/~hudson-openstack/nova/trunk

  1. TrustedComputingPools
  2. Merge into trunk
Proposed by fred yang
Status: Needs review
Proposed branch: lp://qastaging/~fred-yang/nova/TrustedComputingPools
Merge into: lp://qastaging/~hudson-openstack/nova/trunk
Diff against target: 1441 lines (+1393/-0)
9 files modified
nova/scheduler/attestation/__init__.py (+24/-0)
nova/scheduler/attestation/attestation.py (+124/-0)
nova/scheduler/attestation/client.py (+223/-0)
nova/scheduler/attestation/service.py (+204/-0)
nova/scheduler/filters/__init__.py (+1/-0)
nova/scheduler/filters/json_filter_integrity.py (+124/-0)
nova/scheduler/manager_integrity.py (+240/-0)
nova/tests/scheduler/test_json_filter_integrity.py (+251/-0)
nova/tests/scheduler/test_manager_integrity.py (+202/-0)
To merge this branch: bzr merge lp://qastaging/~fred-yang/nova/TrustedComputingPools
Reviewer Review Type Date Requested Status
Paul Voccio (community) Needs Fixing
Sandy Walsh (community) Needs Fixing
Chris Behrens (community) Needs Fixing
Review via email: mp+76134@code.qastaging.launchpad.net

Description of the change

Enable Trusted Computing Pools into Openstack scheduler by adding new filter driver
Spec/Design - http://wiki.openstack.org/TrustedComputingPools
Blueprint discussed at Diablo Summit - https://blueprints.launchpad.net/nova/+spec/trusted-computing-pools

To post a comment you must log in.
Revision history for this message
Chris Behrens (cbehrens) wrote :

This looks really interesting! I haven't done a thorough review yet, but it looks like around line 276, there's extreme indenting. Maybe there are tabs instead of spaces?

review: Needs Fixing
Reply
Revision history for this message
Sandy Walsh (sandy-walsh) wrote :

Thanks Fred ... perhaps we can start with a pep8 cleanup and ensure it complies with the HACKING document. Also if you could remove all the debug/commented out code?

Then we can get into the nitty gritty of it.

review: Needs Fixing
Reply
Revision history for this message
Johannes Erdfelt (johannes.erdfelt) wrote :

I don't know enough about the scheduler to comment on the functionality of the patch, but I do have a style comment. It doesn't seem necessary to split tlvl_string and tlvl_value as separate lists. Especially since the code combines them into a dict at runtime. It's probably cleaner to create a dict literal instead.

Reply
Revision history for this message
Paul Voccio (pvo) wrote :

 Wanted to echo removing comments and some of the formatting the others
 mentioned here.

 I got some 3 failures with the S3APITestCase. Not sure if this is related or
 not yet.
>
  Please also add yourself to the Authors file. This failed on the unit tests
 for me.

>
> ======================================================================
> FAIL: test_authors_up_to_date (nova.tests.test_misc.ProjectTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/root/bzr/TrustedComputingPools/nova/tests/test_misc.py", line 93, in
> test_authors_up_to_date
> '%r not listed in Authors' % missing)
> AssertionError: set([u'<email address hidden>']) not listed in Authors

review: Needs Fixing
Reply
Revision history for this message
fred yang (fred-yang) wrote :

Woop! Learning the process. Should I submit the Authors file now, or I can do another clean-up to submit
Thanks,
-Fred

> Wanted to echo removing comments and some of the formatting the others
> mentioned here.
>
> I got some 3 failures with the S3APITestCase. Not sure if this is related or
> not yet.
> >
> Please also add yourself to the Authors file. This failed on the unit tests
> for me.
>
> >
> > ======================================================================
> > FAIL: test_authors_up_to_date (nova.tests.test_misc.ProjectTestCase)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/root/bzr/TrustedComputingPools/nova/tests/test_misc.py", line 93,
> in
> > test_authors_up_to_date
> > '%r not listed in Authors' % missing)
> > AssertionError: set([u'<email address hidden>']) not listed in Authors

Reply
Revision history for this message
fred yang (fred-yang) wrote :

Will start from pep 8 tool to clearn up ...
Thanks,
-Fred

> Thanks Fred ... perhaps we can start with a pep8 cleanup and ensure it
> complies with the HACKING document. Also if you could remove all the
> debug/commented out code?
>
> Then we can get into the nitty gritty of it.

Reply
Revision history for this message
fred yang (fred-yang) wrote :

Combining sting & value into a dict is good suggestion
Thanks,
-Fred

> I don't know enough about the scheduler to comment on the functionality of the
> patch, but I do have a style comment. It doesn't seem necessary to split
> tlvl_string and tlvl_value as separate lists. Especially since the code
> combines them into a dict at runtime. It's probably cleaner to create a dict
> literal instead.

Reply

Unmerged revisions

1587. By fred yang

First Trusted Computing Pools enabling

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.