Code review comment for lp://qastaging/~free.ekanayaka/landscape-charm/dont-restart-when-leader-is-deposed

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

> Having the assumption that the trigger for leader changing is because the old
> leader is dying feels too broad.

Agreed, however I believe this is "safe enough" in practice for now, and any alternative I see will be significantly more expensive.

> This needs a bug link too.

Agreed: Bug #1625500.

« Back to merge proposal