Code review comment for lp://qastaging/~freyes/charm-helpers/add-set-mysql-password

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Overall, I think the change is mostly fine. I think the value of None for the password parameter poses problems and ambiguity that should definitely be fixed.

review: Needs Fixing

« Back to merge proposal