Charm Helpers

Code review comment for lp://qastaging/~freyes/charm-helpers/add-set-mysql-password

  1. add-set-mysql-password
  2. Merge into devel
Revision history for this message
Felipe Reyes (freyes) wrote :

On Wed, 12 Jul 2017 17:54:06 -0000
Billy Olsen <email address hidden> wrote:

> Review: Needs Fixing
>
> Overall, I think the change is mostly fine. I think the value of None
> for the password parameter poses problems and ambiguity that should
> definitely be fixed.

I agree that None is totally unexpected for an API, but the reasoning of using None is https://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/database/mysql.py#L283

« Back to merge proposal