Code review comment for lp://qastaging/~freyes/charm-helpers/fix-test-ipv6

Revision history for this message
Felipe Reyes (freyes) wrote :

Alex, I'm OK with changing the patch to the approach you suggest, but universal_newlines=True is a widespread approach to deal with py2 vs py3, if you think that it's worth to take a different method to deal with this, I will do the change.

$ find charmhelpers/ -name "*.py" -exec grep universal_newlines {} \; | wc -l
13

« Back to merge proposal