Code review comment for lp://qastaging/~gandelman-a/charms/precise/rabbitmq-server/ceph-support

Revision history for this message
James Page (james-page) wrote :

I'll give this a more better test later this week after UDS - one comment for the time being

1) utils.py/do_hooks()

Hook itself should not be called in the try/except block as KeyErrors will not propagate back up into hook failures with the hook functions themselves - hence the original call to hook_func() in the else block.

« Back to merge proposal