unity-2d

Merge lp://qastaging/~gerboland/unity-2d/panel-f10-keyboard-navigation-fixes into lp://qastaging/unity-2d/3.0

  1. panel-f10-keyboard-navigation-fixes
  2. Merge into natty
Proposed by Gerry Boland
Status: Merged
Approved by: Gerry Boland
Approved revision: 636
Merged at revision: 640
Proposed branch: lp://qastaging/~gerboland/unity-2d/panel-f10-keyboard-navigation-fixes
Merge into: lp://qastaging/unity-2d/3.0
Diff against target: 135 lines (+25/-6)
3 files modified
panel/applets/appname/appnameapplet.cpp (+1/-1)
panel/applets/appname/menubarwidget.cpp (+16/-3)
panel/applets/appname/menubarwidget.h (+8/-2)
To merge this branch: bzr merge lp://qastaging/~gerboland/unity-2d/panel-f10-keyboard-navigation-fixes
Reviewer Review Type Date Requested Status
Florian Boucault (community) Approve
Review via email: mp+68882@code.qastaging.launchpad.net

Description of the change

[panel] F10 shortcut now correctly displays menu for keyboard navigation. Menubar displays when menus are open, and vanishes when menus close.

To post a comment you must log in.
lp://qastaging/~gerboland/unity-2d/panel-f10-keyboard-navigation-fixes updated
635. By Gerry Boland

Fixes F10 menu displaybug, where menu didn't obtain focus and panel covered menubar.

Revision history for this message
Florian Boucault (fboucault) wrote :

Bug is fixed and panel works properly :)

panel/applets/appname/menubarwidget.h:
[...]
/**
 * An helper class which monitors the menubar and emits MenuBarWidget::menuBarClosed()
 * to indiciate if the menu was closed or updated.
 */

has a spelling mistake: "indiciate"

Otherwise the patch looks good.

review: Approve
lp://qastaging/~gerboland/unity-2d/panel-f10-keyboard-navigation-fixes updated
636. By Gerry Boland

Fixed typo "indiciate" -> "indicate"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches