Unity

Merge lp://qastaging/~gordallott/unity/chunked-lazy-load into lp://qastaging/unity

chunked-lazy-load
Merge into trunk

Proposed by Gord Allott on 2011-09-19

Status:

Merged

Approved by:

Mikkel Kamstrup Erlandsen on 2011-09-20

Approved revision:

no longer in the source branch.

Merged at revision:

1586

Proposed branch:

lp://qastaging/~gordallott/unity/chunked-lazy-load

Merge into:

lp://qastaging/unity

Diff against target:

107 lines (+30/-8)

2 files modified

plugins/unityshell/src/ResultViewGrid.cpp (+28/-7)
plugins/unityshell/src/ResultViewGrid.h (+2/-1)

To merge this branch:

bzr merge lp://qastaging/~gordallott/unity/chunked-lazy-load

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Mikkel Kamstrup Erlandsen (community)		2011-09-19	Approve on 2011-09-20
Review via email: mp+76018@code.qastaging.launchpad.net

Description of the change

measures the loading of icons in the dash, if the timeframe exceeds 8ms (half a frame) we wait until the next frame to load more icons

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2011-09-19:

48 + if (timer.ElapsedSeconds() > 0.08)
49 + {
50 + queue_additional_load = true;
51 + break;
...
64 + g_timeout_add(1000/60 - 8, (GSourceFunc)(&ResultViewGrid::OnLazyLoad), this);

On line 48 you have 80ms and on line 64 using 1 frame @ 60 fps - 8ms. Maybe there is some logic I am missing, and you need a comment somewhere to explain it; or you have an off-by-an-order-of-magnitude-error there between 80ms and 8ms ;-)

(maybe comments needed about the timings anyway for dummies like me :-))

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2011-09-19:

Approved modulo my previous comment

review: Approve

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2011-09-19:

I retract that approval! :-)

<kamstrup> gord: approved module that comment then :-)
<gord> yeah i'm just actually checking that everythings fine with the correct time ;)
hrm no, no it is not
<kamstrup> gord: lol, I retract my approval then! :-)

review: Needs Fixing

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2011-09-20:

Code looks good. Tested tile loading speed with ~1k tweest from unity-lens-gwibber. Very noticeable speed up. Nice work!

review: Approve