Code review comment for lp://qastaging/~gordallott/unity/chunked-lazy-load

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

48 + if (timer.ElapsedSeconds() > 0.08)
49 + {
50 + queue_additional_load = true;
51 + break;
...
64 + g_timeout_add(1000/60 - 8, (GSourceFunc)(&ResultViewGrid::OnLazyLoad), this);

On line 48 you have 80ms and on line 64 using 1 frame @ 60 fps - 8ms. Maybe there is some logic I am missing, and you need a comment somewhere to explain it; or you have an off-by-an-order-of-magnitude-error there between 80ms and 8ms ;-)

(maybe comments needed about the timings anyway for dummies like me :-))

« Back to merge proposal