Code review comment for lp://qastaging/~gz/bzr-grep/no_match_fast_path

Revision history for this message
Martin Packman (gz) wrote :

Even with the current checks, this branch changes some corner-cases with line-endings. The existing behaviour isn't all that great, but should really decide on what we want the plugin to do and make it consistent.

I've removed a little of the code for the moment, so the first match will happen twice, but the basic speedup should be the same, and the landing risk should be lower.

« Back to merge proposal