Code review comment for lp://qastaging/~gz/pyjunitxml/split_test_id_before_parameter

Revision history for this message
Vincent Ladeuil (vila) wrote :

Hmm, what are the constraints on a test id ?

I've got the feeling that the (par1,par2) addition is quite bzr specific
and I don't know if we even enforce the constraints that parameter strings should not embed
any funny stuff (say a '(') which will break your fix as well.

14 + class_end = test_id.rfind(".", 0, test_id.find("("))

So I'd be very tempted to ask for a better way than test_id.find("(") to identify
a valid python identifier at the *start* of the test id and then, and only then,
extract the class from that.

review: Needs Fixing

« Back to merge proposal