Code review comment for lp://qastaging/~haggai-eran/nux/rtl-rebased
Revision history for this message
| Jay Taoko (jaytaoko) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
Haggai
Selecting right to left has to be done per layout. Lets say you have an horizontal layout that has a checkbox followed by a button, and the button is followed by a combobox. In LTR order you get this:
checkbox | button | combobox
If you make the HLayout to be RTL then the content will look like this:
combobox| button | checkbox
This should work out fine because only a specific HLayout has been been changed to RTL.
So you have to select only the layouts of the interface that need to be inverted. Rather than having SetDefaultDirection in Nux.cpp, it should be a function member of LinearLayout. Then for each layout (HLayout or VLayout), you will be able to decide if it goes from LTR or RTL. Individual views like the Checkbox, will remain un-affected.
How about that?