Looks great. I have two comments:
1) Do we really need --with-gtk3? Seems like --with-gtk2 is enough.
2) You need to add the following in src/bridge.c:
+#if GTK_CHECK_VERSION(3, 0, 0) +#include <libdbusmenu-gtk3/menuitem.h> +#include <libdbusmenu-gtk3/parser.h> +#else #include <libdbusmenu-gtk/menuitem.h> #include <libdbusmenu-gtk/parser.h> +#endif
Unfortunately (and this is my fault), the headers use different directories for gtk2/gtk3.
« Back to merge proposal
Looks great. I have two comments:
1) Do we really need --with-gtk3? Seems like --with-gtk2 is enough.
2) You need to add the following in src/bridge.c:
+#if GTK_CHECK_ VERSION( 3, 0, 0) gtk3/menuitem. h> gtk3/parser. h> gtk/menuitem. h> gtk/parser. h>
+#include <libdbusmenu-
+#include <libdbusmenu-
+#else
#include <libdbusmenu-
#include <libdbusmenu-
+#endif
Unfortunately (and this is my fault), the headers use different directories for gtk2/gtk3.