Code review comment for lp://qastaging/~hopem/charm-helpers/lp1257763
Revision history for this message
| Cory Johns (johnsca) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> Cory, I am concerned that the test errors (list inversions) caused by newer
> versions of tox are a result of tox causing some unexpected side effects in
> the tests, the scope of which is unclear. It is partially for this reason that
> I decided to pin tox to 1.6.1 which incidentally is the same rule currently
> used in upstream openstack.
The failures that I fixed in my merge are just tests relying on the ordering of of keyword args (i.e., dict items), which is undefined and subject to change at any time. My fixes just remove the strict ordering dependencies by replacing, e.g., assertEqual() with assertItemsEqual(). Without those changes, these tests are pretty much guaranteed to fail at some point.
I'm not averse to pinning the version of tox, but I think those test fixes should be made regardless.