Code review comment for lp://qastaging/~hopem/charm-helpers/lp1257763

Revision history for this message
Cory Johns (johnsca) wrote :

> @corey.johnsca - sounds like the newer versions of tox are just stricter in
> which case it is not a bug and you are absolutely correct. Could we possibly
> apply your suggested fixes as part of a separate patchset in order to avoid
> bloating this one? (if you agree i'll raise a seperate bug to get it fixed).

The problem is that the tox version only incidentally fixes the tests, because the ordering of dict items is arbitrary, even though it is mostly consistent. The docs (https://docs.python.org/2/library/stdtypes.html#dict.items) describe it as:

> CPython implementation detail: Keys and values are listed in an arbitrary
> order which is non-random, varies across Python implementations, and
> depends on the dictionary’s history of insertions and deletions.

Obviously, it's consistent enough that it hasn't been a big concern before now, but if we get these tests running under CI, as should be done, they will likely fail again at some point, even with the fixed version of tox.

That said, I'm fine with making the test fixes as part of a separate MP since they're not exactly related to the tox change and they pass most of the time. I'll go ahead and create the separate MP with just the test fixes.

« Back to merge proposal