Code review comment for lp://qastaging/~huerlisi/vmbuilder/dev

On Wed, May 05, 2010 at 06:32:29AM -0000, Simon Huerlimann wrote:
> Simon Huerlimann has proposed merging lp:~huerlisi/vmbuilder/dev into lp:vmbuilder.

Thank you! Please accept my apologies for the delay. I'll try to respond
in a more timely fashion in the future.

> @@ -234,29 +238,35 @@
> try:
> curdisk = list()
> size = 0
> + count = 0
> for line in file(self.options.part):
> pair = line.strip().split(' ',1)
[...]
> + def do_disk(self, hypervisor, curdisk, size, count):
> default_filesystem = hypervisor.distro.preferred_filesystem()
> - disk = hypervisor.add_disk(util.tmpfile(keep=False), size+1)
> - logging.debug("do_disk - size: %d" % size)
> + if self.options.raw:
> + disk = hypervisor.add_disk(filename=self.options.raw[count])

I took the liberty of renaming "count" to "disk_idx" for clarity.

Other than that, it looks great.

  review approve
  merge approved

--
Soren Hansen
Ubuntu Developer
http://www.ubuntu.com/