Code review comment for lp://qastaging/~jameinel/bzrtools/cygwin-title

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Review: Needs Information
> It looks like this changes the title string so that it says "bzr shell" instead of "bzr", but only in Cygwin. I'm happy with the change, but it seems strange to do it only in Cygwin. Why not use the same title string in both?

Because I wanted it to say 'bzr shell' for me, but didn't want to affect
your default (for whatever reason you chose it).

Though I've since customized it significantly more, and would probably
just have my own plugin that monkeypatches things to match what I want.
(Since I don't really feel like putting the effort into making it
actually configurable like $PS1 is.)

If you'd rather I made it say 'bzr' or 'bzr shell' both places, I'm fine
with that.

John
=:>-
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksq4UkACgkQJdeBCYSNAAPPcQCgxViylTJfmmG3z0yF7APYWRM0
vZwAn0SinrV0cnBY53do/VATfnmML4jH
=Tsea
-----END PGP SIGNATURE-----

« Back to merge proposal