Charm Helpers

Merge lp://qastaging/~james-page/charm-helpers/ceph-redux into lp://qastaging/charm-helpers

ceph-redux
Merge into devel

Proposed by James Page on 2013-08-13

Status:	Merged
Merged at revision:	77
Proposed branch:	lp://qastaging/~james-page/charm-helpers/ceph-redux
Merge into:	lp://qastaging/charm-helpers
Diff against target:	1104 lines (+721/-314) 4 files modified charmhelpers/contrib/hahelpers/ceph.py (+0/-294) charmhelpers/contrib/storage/linux/ceph.py (+336/-0) tests/contrib/storage/test_linux_ceph.py (+351/-20) tests/helpers.py (+34/-0)
To merge this branch:	bzr merge lp://qastaging/~james-page/charm-helpers/ceph-redux
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Adam Gandelman (community)		2013-08-13	Approve on 2013-09-23
Review via email: mp+179948@code.qastaging.launchpad.net

Description of the change

Redux of ceph helper

Include unit testing and re-location to a more sensible location.

lp://qastaging/~james-page/charm-helpers/ceph-redux updated on 2013-09-23

56. By James Page on 2013-08-23: Rebase on trunk
57. By James Page on 2013-08-23: Tidy lint in test_linux_ceph
58. By James Page on 2013-09-23: Rebase on trunk, fixup test errors

Revision history for this message

Adam Gandelman (gandelman-a) wrote on 2013-09-23:

LGTM. At this point we should probably have all tests that use patch_open()/mock_open() using the same copy.

review: Approve

Revision history for this message

James Page (james-page) wrote on 2013-09-23:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 23/09/13 18:18, Adam Gandelman wrote:
> LGTM. At this point we should probably have all tests that use
> patch_open()/mock_open() using the same copy.

Agreed - I'll find some time todo a global refactor of that bit.

- --
James Page
Ubuntu and Debian Developer
<email address hidden>
<email address hidden>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJSQKb7AAoJEL/srsug59jD6hkQAIajDJ8OoaP2dUv9IPeIoBSP
Rffbl+Wc0yZp6YdEP+Krw2u63LQZlplOXoYvwDnKonSaamOcYS1RpS51Mcv4TQ6i
YowB4X9/q7mPYczm/Sj3MDxOwWg+GWkhGX1DukzZSyrLiUs0Lfpd0s6EFISo70vT
0Z7FEqzLrULZ/5LEfkhIuZ/6Lw+xZbckOkvhoZU5mRgYe/p9jrLJsWastmk8m6No
jhsLEq5WoKro2Ytco4cBywSjyIcON6n36DGw1qR9lwFgep+N6d/WqNDdgvmS+DAJ
KP/d5+a6limRehw7zqPJiCMqG23zr3AoG7JRxRQkKjzRi3CJc/3QPg0+k8sp9Ll2
NUOIFCAOM8ST6hKoyi/rCTI0neVVzqTzc+sAnUYZU6cBA80LDTeVRxePPk6lY/fQ
Gz2YAUhBWpt1GVE+VOYDiECxsBFiPMFuNF0jwVnQxfxW7OOeqdBY8Su/u/Muge1M
djPoo6YpOHi9AVfMCNc8E8rmrnNJzW7vCOQVc0xtG05r9WJ+PoznSEwDzVjOqjhN
Nk/lyVRgdzpLdq3TAX/RKLMKuYJFNdt8I+xAu3KEc6+WE2GVM5gsvuBA1m/W0Mwq
zOLBTV7IHnMBfLIsK+iPTqOmNj9huDeHEWnrl/3/qmojN6keIIs9Mx1sB0shT9CW
2W+tTSOeYBPUJh3tvoUV
=dwG/
-----END PGP SIGNATURE-----

Revision history for this message

Adam Gandelman (gandelman-a) wrote on 2013-09-23:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/23/2013 01:42 PM, James Page wrote:
> On 23/09/13 18:18, Adam Gandelman wrote:
> > LGTM. At this point we should probably have all tests that use
> > patch_open()/mock_open() using the same copy.
>
> Agreed - I'll find some time todo a global refactor of that bit.
>

Filed this earlier for at least patch_open/mock_open:

https://code.launchpad.net/~gandelman-a/charm-helpers/test_helpers/+merge/187074
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSQKpnAAoJEGAsEdGd4tyVCTEH/2yefCxcivHLVz6kMtAOvL8C
wPP+Q9s6e7bKlrAunF2IOQmOn2v46eOa6AOdrJ87kS5XKF/sulpwpx3asscfaVIM
9vQZalw6HCwGmmFqh5BepbdDDj3ULLNf1898JvhjPyvuuHJGqSQMY0qbCxe6L3Ec
T/1RLtJ8+JJKFhP4EWZbzl4Q8qYilr3ToWACGZ/yQgnYsVKC4n7vc0+BBisUtOpD
Bj6vLaIzT1SO1ZsEo9NnZmj5zdnnrXnwgSlHvoFHtL0UEr+ngjWY/CE3dRMerBoS
LGGONAXmPYTGnb7HYPF5Rj82CCkc4JX5vQ9f46vc+fWcebE1Z6N3A98YsGus+ZE=
=h4Sb
-----END PGP SIGNATURE-----