Code review comment for lp://qastaging/~james-page/charm-helpers/ceph-redux

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/23/2013 01:42 PM, James Page wrote:
> On 23/09/13 18:18, Adam Gandelman wrote:
> > LGTM. At this point we should probably have all tests that use
> > patch_open()/mock_open() using the same copy.
>
> Agreed - I'll find some time todo a global refactor of that bit.
>

Filed this earlier for at least patch_open/mock_open:

https://code.launchpad.net/~gandelman-a/charm-helpers/test_helpers/+merge/187074
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSQKpnAAoJEGAsEdGd4tyVCTEH/2yefCxcivHLVz6kMtAOvL8C
wPP+Q9s6e7bKlrAunF2IOQmOn2v46eOa6AOdrJ87kS5XKF/sulpwpx3asscfaVIM
9vQZalw6HCwGmmFqh5BepbdDDj3ULLNf1898JvhjPyvuuHJGqSQMY0qbCxe6L3Ec
T/1RLtJ8+JJKFhP4EWZbzl4Q8qYilr3ToWACGZ/yQgnYsVKC4n7vc0+BBisUtOpD
Bj6vLaIzT1SO1ZsEo9NnZmj5zdnnrXnwgSlHvoFHtL0UEr+ngjWY/CE3dRMerBoS
LGGONAXmPYTGnb7HYPF5Rj82CCkc4JX5vQ9f46vc+fWcebE1Z6N3A98YsGus+ZE=
=h4Sb
-----END PGP SIGNATURE-----

« Back to merge proposal