Code review comment for lp://qastaging/~james-page/charm-helpers/get_network_addresses-refactor

Revision history for this message
David Ames (thedac) wrote :

James,

Sorry for the long delay on this. I have finally completed some testing. My original concern was the removal of vip information. But I have proven to myself that
  endpoint = resolve_address(net_type)
Does the right thing.

Approved. Merging.

I'll also look closely at this for the dual stack bits.

review: Approve

« Back to merge proposal