Code review comment for lp://qastaging/~james-page/ubuntu/quantal/samba/cups-integration

Revision history for this message
Steve Langasek (vorlon) wrote :

+ - d/samba.reload-smbd.upstart: Add upstart task which reloads smbd
<snip>
=== added file 'debian/samba.reload-smbd.conf'

mismatched names; should really be .upstart.

Also, looks like a change to debian/rules is missing here to get debhelper to install the added script (dh_installinit -psamba --upstart-only --no-start --name reload-smbd)

Otherwise, looks good.

review: Needs Fixing

« Back to merge proposal