Code review comment for lp://qastaging/~james-w/desktopcouch/context-for-tests

Revision history for this message
Eric Casteleijn (thisfred) wrote :

This looks like a great improvement! I would love for the tests *not* to use the user's keyring, which always seemed wrong to me. It's probably way beyond the scope of this branch, but the ideal way of testing realistic authentication would be to use a fake/mock keyring.

All tests green.

review: Approve

« Back to merge proposal