Code review comment for lp://qastaging/~jason-koelker/nova/lp819477

Still quite a bit broken. I got most of the way there like this:

http://paste.openstack.org/show/2350/

most of those errors are caught by pyflakes, btw. I highly recommend you get it running automatically in your editor.

Remaining issues:

There are still a bunch of references to instance['fixed_ips'] and fixed['network'] in cloud.py that will cause metadata and describe instances to fail.

The network creation is still failing in my tests because vlan and bridge aren't getting set automatically by the command:
nova-manage network create private 10.0.0.0/24 1 256

vpn_public_address and vpn_public_port really seem like they should be properties of the network, not the subnet, and i worry that anything involving them is seriously broken. Nova-manage commands, ip forwarding rules, cloudpipe launching etc.