Code review comment for lp://qastaging/~jason-koelker/nova/lp819477

Revision history for this message
Rick Harris (rconradharris) wrote :

Really nice work here Jason.

A couple of micro-nits (would be nice-to-have fixes, but not enough to hold up the patch):

> 847 + i = subnets.insert()

Would prefer non-single-letter-vars, maybe `insert_stmt`.

> 1826 + if not network:
> 1827 + raise ValueError(_('Network already exists!'))
> 1828 + else:
> 1829 + nw_data.append(network)

A bit of a double negative with the else, perhaps:

if network:
    nw_data.append(network)
else:
    raise ValueError(_('Network already exists!'))

« Back to merge proposal