Code review comment for lp://qastaging/~jason-koelker/nova/lp819477

> > The network creation is still failing in my tests because vlan and bridge
> > aren't getting set automatically by the command:
> > nova-manage network create private 10.0.0.0/24 1 256
>
> I'm still looking at this.

I think this is now taken care of. Please advise if it is not.

> > vpn_public_address and vpn_public_port really seem like they should be
> > properties of the network, not the subnet, and i worry that anything
> involving
> > them is seriously broken. Nova-manage commands, ip forwarding rules,
> > cloudpipe launching etc.
>
> Well I *think* that by moving them along with the subnet that you should get
> one per subnet. But I don't have a setup to test them. I'll see if I can get
> my xenserver to play with vlan manager nicely.

I updated the `nova-manage vpn change` command to update the subnet. I couldn't find any other references to vpn_ in it please let me know if there are others I am missing.

The forwarding rules (I assume ensure_vpn_forward in linux_net) are getting the port and private address passed to them from the subnet table as they are getting called once per subnet per network. This should allow for the updating of the VPN system to handle multiple networks/subnet nicely (currently it just takes the 1st network it finds for a project).

I also updated the auth/manager's get_project_vpn_data to return the data for the 1st v4 subnet on the network. I *think* this is correct and will work, but I don't have the setup to test cloudpipe instances extensively. Please let me know if its still not working as expected.