Code review comment for lp://qastaging/~jason-koelker/nova/lp819477

On Mon, 2011-09-12 at 01:52 +0000, Dan Prince wrote:
> Review: Needs Fixing
>
> Hi Jason,
>
> I'm getting errors when using FlatDHCP w/ this branch (via Smokestack):
>
> InvalidRequestError: Object '<Subnet at 0x3840510>' is already attached to session
>
> Paste stack trace available here:
>
> http://paste.openstack.org/show/2413/

Do you happen to have the full stack trace so I can see where this is
happening at?

> ---
>
> Also. You have some conflicts to fix with the latest nova trunk:
>
> Text conflict in bin/nova-manage
> Text conflict in nova/db/api.py
> Text conflict in nova/db/sqlalchemy/api.py
> Text conflict in nova/db/sqlalchemy/models.py
> Text conflict in nova/exception.py
> Text conflict in nova/tests/test_network.py

Yea, I have the conflicts fixed locally, but the quantum unit tests now
fail since they mock out their own network data. Working on fixing those
before I push again.

Happy Hacking!

7-11