Unity

Code review comment for lp://qastaging/~jassmith/unity/unity.redraw-on-resume

  1. unity.redraw-on-resume
  2. Merge into trunk
Revision history for this message
Tim Penhey (thumper) wrote :

Why add <gio/gio.h> ?

Instead of assigning, use reset:

proxy_.reset(new unity::glib::DBusProxy("org.freedesktop.UPower",
                                        "/org/freedesktop/UPower",
                                        "org.freedesktop.UPower",
                                        G_BUS_TYPE_SYSTEM);

Since you use a lambda function, and not sigc::mem_fun, this won't be automatically disconnected when the launcher controller dies. Could there be a situation where this occurs? Or not?

review: Needs Fixing

« Back to merge proposal