Code review comment for lp://qastaging/~jaypipes/drizzle/publisher-read-manifest

Revision history for this message
Brian Aker (brianaker) wrote :

Hi!

I would rather not see replication.proto move out of the kernel and off into the plugin. Basic reason why? If I start to develop a replication piece for Drizzle, I am going to want to use whatever is shipped with the kernel. If this piece is moved off I am likely to just develop my own.

Also? I think we should be pretty standard in our use of proto. Schema, Table, Row all have usage beyond just replication. If we start picking this stuff out we will likely end up finding ourselves with multiple.

On testing frameworks. We have one, Monty has one in his tree, and Eric has another. This is a lot of unit testing. Lets come up with a plan for one (and one that is used by many, not few).

Cheers,
   -Brian

review: Needs Information

« Back to merge proposal