Code review comment for lp://qastaging/~jaypipes/drizzle/publisher-read-manifest

Revision history for this message
Monty Taylor (mordred) wrote :

On 05/07/2010 12:04 PM, Jay Pipes wrote:

> On unittests:
>
> You said you wanted tests of the replication system? I used the same
> method of testing that Eric did for the mysql_protocol module. The
> current test-run.pl cannot test the things that are being tested
> here. Please let me know how you want me to change things. Thanks.

My suggestion here is this:

Keep Jay's system and Eric's system for now. Test-run is in need of a
good overhauling anyway. We've got a summer of code student who is going
to be working on code-level unittesting. At that point, we should have
enough examples and data to work from to do a proper refactoring into
something we can actually use and that meets all of the needs we have.
(Consider this prototyping and requirements gathering)

I fear if we try to just quickly do something consistent right now we'll
wind up with something just as ass-tastic as test-run.

Monty

« Back to merge proposal