Merge lp://qastaging/~jdstrand/snap-confine/preprocessor into lp://qastaging/~snappy-dev/snap-confine/trunk
Proposed by
Jamie Strandboge
Status: | Merged |
---|---|
Merged at revision: | 113 |
Proposed branch: | lp://qastaging/~jdstrand/snap-confine/preprocessor |
Merge into: | lp://qastaging/~snappy-dev/snap-confine/trunk |
Diff against target: |
169 lines (+76/-28) 3 files modified
debian/changelog (+1/-0) src/seccomp.c (+73/-28) tests/test_restrictions_working (+2/-0) |
To merge this branch: | bzr merge lp://qastaging/~jdstrand/snap-confine/preprocessor |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tyler Hicks (community) | Needs Fixing | ||
Snappy Developers | Pending | ||
Review via email: mp+290652@code.qastaging.launchpad.net |
Description of the change
preprocess the seccomp file for '@' directives. Right now this is only a small refactor and preprocessing for @unrestricted, but this sets up future directives like @deny rules and @complain.
To post a comment you must log in.
There's one serious bug that needs fixing (mentioned inline).
I'm having a little trouble understanding the bigger picture of why we need to preprocess. The card corresponding to this MP suggests that it us for @deny and I don't know exactly what @deny will do so could you briefly explain why preprocessing is needed for @deny?