Code review comment for lp://qastaging/~jelmer/bzr/fix-for-105432

Revision history for this message
Martin Pool (mbp) wrote :

So what are we going to do here?

<https://bugs.launchpad.net/bzr/+bug/105432> has some good background. I think generally, arguments that we ought to add a new name or a new alias because people would look for it under that name, are not very convincing: we can do something within the help system or documnetation that will be cheaper. However, here:

 * it is worth having a clear opposite of remove-tree
 * with this landed, 'bzr checkout' can lose its no-argument default to making a tree in the enclosing branch, and be only for making a bzrdir and tree

and, fwiw, jam, james_w and abentley are in favour of it in that bug.

[fix] If this patch proceeds, the new command ought to be mentioned in whatsnew and in the user guide. It is easier and more reliable to update those docs when the feature is added, not later.

On the whole I would merge it but we can try to get more consensus first.

> One of the great strengths of bzr is exactly the clean(ish) separation of concerns among repo/branch/wt, and the ability to arrange them as appropriate locally. That opens up enough possibility for confusion; creating whole different commands for "create working tree" based on where it is relative to the other pieces just it worse.

I agree that's a strength; can you explain more why adding this would harm it?

« Back to merge proposal