Code review comment for lp://qastaging/~jjo/charms/trusty/nova-cloud-controller/fix-haproxy-cfg-for-neutron-api-lp1476394

Revision history for this message
David Ames (thedac) wrote :

JuanJo,

Thanks for the bug report and the MP.

As I mentioned on IRC I would like the scenario that leads to haproxy config being incorrect. If you have a juju-deployer config or just a simple setup example I would appreciate it.

I suspect we are going to want to use if not relation_ids('neutron-api') rather than is_relation_made as it is slightly less stringent and my concern is this is potentially racey. The neutron-api relation may not yet exist when the HAProxy context is called.

Unfortunately, we had problems with serverstack so I was unable to test my theories.

review: Needs Information

« Back to merge proposal