Code review comment for lp://qastaging/~jml/canonical-identity-provider/clean-up-temp

Revision history for this message
James Westby (james-w) wrote :

Hi,

This looks ok to me, though I'm a little confused about why it's ok to remove the
dir at the end if it isn't at the beginning.

Natalia had a comment on IRC:

<nessita> jml: I'm looking at https://code.launchpad.net/~jml/canonical-identity-provider/clean-up-temp/+merge/143537, I was wondering if we can somehow avoid the duplication of the code

Thanks,

James

review: Approve

« Back to merge proposal