Code review comment for lp://qastaging/~jocave/snapcraft/plainbox-provider-plugin

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Wed, Aug 19, 2015 at 8:19 AM, Zygmunt Krynicki <
<email address hidden>> wrote:

> (and what I mean by sorry is that I'm not sure if this pulls in python to
> the snap (wrong) or on the host to build the snap (correct but we then also
> require a >= version of plainbox to boot).

Hmm, maybe an example inside examples would clear things up with the
intentions of this plugin, but you need to either depend on the plugin
which would make it part of the final snap or add a build-depends to the
yaml for constructing this.

I guess in any case, for a plugin we need an E2E working example inside
'examples' to not have a half baked plugin.

« Back to merge proposal