Charm Helpers

Code review comment for lp://qastaging/~joeborg/charm-helpers/snap-install

  1. snap-install
  2. Merge into devel
Revision history for this message
David Ames (thedac) wrote :

Looks good. Just a couple of requests.

Please create a specific Exception to raise in line 66.

And please explicitly add log severity to to lines 91,112 and 133

log("MESSAGE", level='ERROR')

review: Needs Fixing

« Back to merge proposal