UTAH

Merge lp://qastaging/~joetalbott/utah/fix_duplicate_docstrings into lp://qastaging/utah

fix_duplicate_docstrings
Merge into dev

Proposed by Joe Talbott on 2012-12-11

Status:

Merged

Approved by:

Javier Collado on 2012-12-11

Approved revision:

783

Merged at revision:

785

Proposed branch:

lp://qastaging/~joetalbott/utah/fix_duplicate_docstrings

Merge into:

lp://qastaging/utah

Diff against target:

21 lines (+2/-2)

1 file modified

utah/client/tests/test_state_agent.py (+2/-2)

To merge this branch:

bzr merge lp://qastaging/~joetalbott/utah/fix_duplicate_docstrings

Medium

Triaged

Link a bug report

Reviewer	Date Requested	Status
Javier Collado (community)	2012-12-11	Approve on 2012-12-11
Joe Talbott (community)		Needs Resubmitting on 2012-12-11
Review via email: mp+139212@code.qastaging.launchpad.net

Description of the change

This branch fixes the docstrings that were duplicated in some testcases.

Revision history for this message

Javier Collado (javier.collado) wrote on 2012-12-11:

When looking at a failure in nosetests output, if the method contains a
docstring, it prints the first line as an id of the test case:

======================================================================
ERROR: Test that a partially run state file with all jobs done
----------------------------------------------------------------------

Hence, if the first line is in the docstring is still the same one, the problem
isn't fixed. To be more specific, the test cases involved are:

test_load_state_partial
test_load_state_partial_run_all
test_load_state_partial_done_all_failed

review: Needs Fixing

lp://qastaging/~joetalbott/utah/fix_duplicate_docstrings updated on 2012-12-11

783. By Joe Talbott on 2012-12-11: test_state_agent - Shorten docstrings and make them unique.

Revision history for this message

Joe Talbott (joetalbott) wrote on 2012-12-11:

I didn't realize it only uses the first line. This is actually one thing I don't like about nosetests. I've shortened the docstrings back to a single unique line.

review: Needs Resubmitting

Revision history for this message

Javier Collado (javier.collado) wrote on 2012-12-11:

Thanks for the update.

review: Approve