Code review comment for lp://qastaging/~johannes.erdfelt/nova/bug747394

Revision history for this message
Brian Waldon (bcwaldon) wrote :

> It's only named 'current' for consistency with other code (see add_to_xenstore
> and remove_from_xenstore).
>
> I'm certainly not attached to that naming but I was hesitant to clean up the
> rest of the code at this point.
>
> Would something like 'entries' or similar work?

Sure, that would work. I'm also not sure what official protocol on using the same variable name back to back like that is. Otherwise, this fix looks good

review: Approve

« Back to merge proposal